fix: Orchestrator schema mismatch & robustness #41
Conversation
- Updated `GovernanceOrchestrator._create_manual_review_ticket` to use `issue.description` instead of `issue.message` to align with the SQLAlchemy `Issue` model. - Added explicit cycle checking in `build_execution_plan` using `nx.is_directed_acyclic_graph` to prevent silent failures. - Verified fix with `tests/test_orchestrator_fixes.py` using a mock model matching the production schema.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
Fixed bugs identified during review of the Task Orchestrator implementation:
Issuemodel usesdescription, but the code was accessingmessage. Updated the_create_manual_review_ticketmethod to access the correct field safely.build_execution_planmethod to explicitly check for cycles usingnx.is_directed_acyclic_graphbefore attempting topological sort, ensuring clear error reporting instead of relying on a pass block.tests/test_orchestrator_fixes.py).PR created automatically by Jules for task 5562410471260917456 started by @turtacn