feat: add TypeScript-style array shorthand syntax T[]
#36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `String[]` as alternative to `Array<String>` - Support nested arrays: `Integer[][]` → `Array[Array[Integer]]` - Support nullable arrays: `String[]?` → `(Array[String] | nil)` - Support arrays of nullable elements: `String?[]` → `Array[String?]` - Support union type arrays: `(String | Integer)[]` - Both syntaxes produce identical IR and RBS output - Add parse_postfix_type_operators for `[]` and `?` suffix handling - Add comprehensive unit tests (15 cases) and E2E tests (14 cases) - Update README examples to show new syntax
Ruby 4.0 skips listen gem installation, but CI runs on Ruby 3.x which requires it. Restore the original Gemfile.lock from main branch.
TypeParser now handles all type parsing including: - Simple types, generics, array shorthand, union, intersection, function types Remove legacy fallback code that was never executed, improving code coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
String[]as an alternative toArray<String>Integer[][]), nullable arrays (String[]?), and arrays of nullable elements (String?[])Changes
parse_postfix_type_operatorsmethod for handling[]and?postfix operatorsTokenDeclarationParserandTypeParserto support array shorthand syntaxExamples
Test plan
bundle exec rspec spec/t_ruby/token_declaration_parser_spec.rb- 32 examples passbundle exec rspec spec/e2e/array_shorthand_spec.rb- 14 examples pass (2 pending)bundle exec rspec- 3270 examples, 0 failures