-
Notifications
You must be signed in to change notification settings - Fork 17
Update German, Portuguese and Albanian patterns #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
For clarification: The patterns are taken straight from https://github.com/hyphenation/tex-hyphen/tree/master/hyph-utf8/tex/generic/hyph-utf8/patterns/tex I then used |
|
Isn't the https://github.com/typst/hypher#languages also should be updated? |
Depends whether that is supposed to be for the current release or not I guess. Edit: I updated them. |
|
Apparently a lot of them are incorrect or imprecise, so the whole list needs updating. I'm surprised there is no script for this in the repo. Even better if it auto updates it into PR. |
That sounds out of scope for this pr. In any case, is the list even needed? It's just the file sizes of the .bin files |
|
I was wondering the same thing. |
|
The list is there because it was a goal to make it smaller than the binary overhead of the |
|
The files differ slightly from the upstream ones. E.g. in https://github.com/hyphenation/tex-hyphen/blob/f44dcc0196939896f40c80e4dc888be0af8822e7/hyph-utf8/tex/generic/hyph-utf8/patterns/tex/hyph-de-1996.tex the patterns are not indented in the |
Not intentionally, but it may have been automatically indented by texfmt. I'll fix it. |
|
I've updated them, and made sure the formatter didn't run. Sorry for the confusion. |
|
Thanks! |
Closes #18
Hopefully I did it correctly