Skip to content

Add open fullyQualifiedName #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
listrophy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add open fullyQualifiedName #486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions Sources/NeedleFoundation/Component.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,13 +169,21 @@ open class Component<DependencyType>: Scope {

public var localTable = [String:()->Any]()
public var keyPathToName = [PartialKeyPath<DependencyType>:String]()


/// Fully qualified name of the Component, such as `"MyParentClass.EnumThatIsAComponent"`
///
/// The default implementation uses `String(describing: self)`, which can be a bit slow. Override this
/// with a faster implementation (such as a hard-coded `String`) if you've identified slowness due to this property.
open var fullyQualifiedName: String {
String(describing: self)
}

// MARK: - Private

private let sharedInstanceLock = NSRecursiveLock()
private var sharedInstances = [String: Any]()
private lazy var name: String = {
let fullyQualifiedSelfName = String(describing: self)
let fullyQualifiedSelfName = fullyQualifiedName
let parts = fullyQualifiedSelfName.components(separatedBy: ".")
return parts.last ?? fullyQualifiedSelfName
}()
Expand Down Expand Up @@ -266,12 +274,20 @@ open class Component<DependencyType>: Scope {
return dependency[keyPath: keyPath]
}

/// Fully qualified name of the Component, such as `"MyParentClass.EnumThatIsAComponent"`
///
/// The default implementation uses `String(describing: self)`, which can be a bit slow. Override this
/// with a faster implementation (such as a hard-coded `String`) if you've identified slowness due to this property.
open var fullyQualifiedName: String {
String(describing: self)
}

// MARK: - Private

private let sharedInstanceLock = NSRecursiveLock()
private var sharedInstances = [String: Any]()
private lazy var name: String = {
let fullyQualifiedSelfName = String(describing: self)
let fullyQualifiedSelfName = fullyQualifiedName
let parts = fullyQualifiedSelfName.components(separatedBy: ".")
return parts.last ?? fullyQualifiedSelfName
}()
Expand Down