Skip to content

Conversation

@matthew-li
Copy link
Collaborator

Description

**** Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. ****

Fixes #676

  • Divided the google_sheets backend into two new backends: brc_google_sheets and lrc_google_sheets, which now have subtle differences in logic:
    • Each backend expects slightly different fields exclusive to it.
    • Each backend has logic for determining whether a row in the sheet should be excluded.
  • Updated tests.
  • Updated YML configuration, given the changes to the available backends.

Type of change

**** Please delete options that are not relevant. ****

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

**** Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. ****

  • Ensure that Pytest tests pass by running pytest.
  • Modify YML configuration and regenerate settings.
  • Run refresh_hardware_procurements_cache and ensure that no errors occur.

PR Self Evaluation

Strikethrough things that don’t make sense for your PR.

  • My code follows the agreed upon best practices
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if needed)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in the appropriate modules
  • I have performed a self-review of my own code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants