feat: spigot support 1.17.1 #107
Conversation
tunagohan
force-pushed
the
feature/1.17.1-support
branch
from
a9265fd to
8338560
Compare
src/main/resources/plugin.yml
Outdated
| softdepend: [Vault,LuckPerms] | ||
| author: ucchy | ||
| api-version: 1.13 | ||
| api-version: 1.17 |
There was a problem hiding this comment.
I suppose this is necessary to support sending newer blocks? But otherwise I don't see why an api-version bump is needed.
There was a problem hiding this comment.
In my opinion, we should take what we can get when we can get it.
The reason is that I don't see the benefit of using an older API version.
There was a problem hiding this comment.
This will prevent the plugin from working on these older versions though. Hence why I'd leave this to the maintainer to decide if compatibility should be broken or not.
Of course, this may be relevant if the json has changed.
pom.xml
Outdated
| <artifactId>UndineMailer</artifactId> | ||
| <version>1.10.3</version> | ||
| <description></description> | ||
| <version>1.11</version> |
There was a problem hiding this comment.
I'd avoid doing version changes in PRs as there may be other changes included in a version bump.
There was a problem hiding this comment.
Yes, sir.
Am I correct in thinking that this is something that the owner specifies when there is a Release?
2 participants
Added support for Spigot 1.17.1 version.
🔑 Changes
PermissionEX will be deprecated in the future.
Implemented LuckPerms instead of PermissionEX for permission management.
LuckPerms
Tests
mvm
Local Server