fix(cts): Fix TypeScript errors, lint warnings, and ApiResponse serialization #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lization - Fix ApiResponse DeclaredType to prevent JsonDerivedType cast failures - Remove invalid v-bind spread on q-form causing TypeScript error - Remove unused imports in AssessmentEpaEdit (watch, types, components) - Convert synchronous DB calls to async (Count, BeginTransaction) - Remove unused variables shadowing injected dependencies - Add AttributeUsage to ApiResponseAttribute for clarity - Fix Vue template key warnings and strict equality in MyAssessments
rlorenzo
changed the title
There was a problem hiding this comment.
Pull request overview
This PR addresses multiple TypeScript, linting, and serialization issues across both C# backend and Vue frontend components. The changes improve code quality, fix runtime bugs, and ensure consistent adherence to framework best practices.
Key Changes:
- Fixed critical JsonDerivedType serialization failures by synchronizing ApiResponse DeclaredType
- Converted synchronous database operations to async patterns for better scalability
- Applied strict equality checks and removed invalid Vue directives causing TypeScript errors
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| web/Classes/ApiResponseAttribute.cs | Added AttributeUsage decorator, fixed DeclaredType synchronization to prevent JsonDerivedType cast failures, removed unused variable |
| web/Areas/CTS/Controllers/AssessmentController.cs | Converted Count/BeginTransaction to async variants, removed unused imports and variables, eliminated unnecessary casts |
| VueApp/src/CTS/pages/MyAssessments.vue | Applied strict equality operators, fixed v-for keys, improved null/undefined checks, reformatted for consistency |
| VueApp/src/CTS/pages/AssessmentEpaEdit.vue | Removed invalid v-bind spread, converted to kebab-case prop bindings, removed unused imports, applied code formatting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Set DeclaredType on ApiResponse to fix JsonDerivedType serialization - Add unit tests for ApiResponseAttribute serialization behavior - Suppress dotnet build verbosity for cleaner verify-build output
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.