Skip to content

Conversation

@rlorenzo
Copy link
Contributor

  • Change DateTime.UtcNow to DateTime.Now for schedule audit and modification timestamps to match existing database conventions
  • Fix undefined variable bug in lint-staged-dotnet.js (effectiveProjectName was never defined, should be projectName)
  • Remove redundant --no-build flag from test-dotnet.js (flag is ignored when testing a pre-compiled DLL directly)
  • Update README.md to clarify lint:staged and precommit command purposes

- Change DateTime.UtcNow to DateTime.Now for schedule audit and
  modification timestamps to match existing database conventions
- Fix undefined variable bug in lint-staged-dotnet.js (effectiveProjectName
  was never defined, should be projectName)
- Remove redundant --no-build flag from test-dotnet.js (flag is ignored
  when testing a pre-compiled DLL directly)
- Update README.md to clarify lint:staged and precommit command purposes
Copilot AI review requested due to automatic review settings December 16, 2025 20:21
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes timestamp handling in the clinical scheduler to match database conventions and resolves several script-related bugs. The main change ensures that audit and modification timestamps use local time (DateTime.Now) instead of UTC, aligning with SQL Server's GETDATE() behavior. Additional fixes improve the reliability of the build tooling scripts.

  • Changes DateTime.UtcNow to DateTime.Now for all schedule audit and modification timestamps in the clinical scheduler
  • Fixes undefined variable bug in lint-staged-dotnet.js (effectiveProjectName → projectName)
  • Removes redundant --no-build flag when testing pre-compiled DLL
  • Updates README documentation to correctly reference npm scripts

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
web/Areas/ClinicalScheduler/Services/ScheduleEditService.cs Updates ModifiedDate assignments to use DateTime.Now in 4 locations (schedule creation and evaluator updates)
web/Areas/ClinicalScheduler/Services/ScheduleAuditService.cs Updates TimeStamp assignment to use DateTime.Now for audit entry creation
scripts/lint-staged-dotnet.js Fixes bug where undefined effectiveProjectName variable was referenced instead of projectName in cache operations
scripts/test-dotnet.js Removes redundant --no-build flag from dotnet test command when testing DLL directly
README.md Corrects npm script references from lint:precommit to precommit and clarifies their purposes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rlorenzo rlorenzo requested a review from bsedwards December 16, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants