Export pathways to PDf #127
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
reginawang3495
left a comment
reginawang3495
left a comment
There was a problem hiding this comment.
nice work! gave you some image help through slack but lmk if there's anything else I can do for you :)
Here is just a quick PR shape review
| @@ -0,0 +1,117 @@ | |||
| import { Link, Document, Page, Text, View, StyleSheet, Font } from "@react-pdf/renderer"; | |||
|
|
|||
| const PathwayPDF = ({ resources }) => { | |||
Contributor
There was a problem hiding this comment.
I haven't seriously looked into it, but I wonder if we can effectively reduce duplicate code by having the PathDay component use View, Document, etc from @react-pdf/renderer.
I took a quick look and it seems possible, but I could be wrong. Maybe take a bit of time and if doesn't work easily lmk and I might take a look as well!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix export pathways to PDF (minus showing pathway images) #95