Skip to content

Added the property hasRequestPending to 'app' object #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
calvimor wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added the property hasRequestPending to 'app' object #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions 2-31/scripts/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,21 +165,27 @@
caches.match(url).then(function(response) {
if (response) {
response.json().then(function(json) {
json.key = key;
json.label = label;
app.updateForecastCard(json);
// Only update if th XHR is still pending, otherwise the XHR
// has already returned and provided the latest data
if( app.hasRequestPending ) {
json.key = key;
json.label = label;
app.updateForecastCard(json);
}
});
}
});
}
// Make the XHR to get the data, then update the card
app.hasRequestPending = true;
var request = new XMLHttpRequest();
request.onreadystatechange = function() {
if (request.readyState === XMLHttpRequest.DONE) {
if (request.status === 200) {
var response = JSON.parse(request.response);
response.key = key;
response.label = label;
app.hasRequestPending = false;
app.updateForecastCard(response);
}
}
Expand Down