Skip to content

Sourcery Starbot ⭐ refactored umadesai/nyt-cli #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
SourceryAI wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Sourcery Starbot ⭐ refactored umadesai/nyt-cli #2

SourceryAI wants to merge 1 commit into from

Conversation

@SourceryAI
Copy link

@SourceryAI SourceryAI commented Nov 30, 2020 •
edited by umadesai
Loading

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch https://github.com/sourcery-ai-bot/nyt-cli master
git merge --ff-only FETCH_HEAD
git reset HEAD^

SourceryAI
SourceryAI commented Nov 30, 2020
View reviewed changes
nyt_cli.py
Comment on lines -19 to +26
stories = []
for i in range(0, count if count <= 10 else 10):
stories.append((response.json()['results'][i]['title'],
response.json()['results'][i]['byline'],
response.json()['results'][i]['url']))
return stories
return [
(
response.json()['results'][i]['title'],
response.json()['results'][i]['byline'],
response.json()['results'][i]['url'],
)
for i in range(count if count <= 10 else 10)
]
Copy link
Author

@SourceryAI SourceryAI Nov 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function top_stories refactored with the following changes:

  • Replace range(0, x) with range(x) (remove-zero-from-range)
  • Convert for loop into list comprehension (list-comprehension)
  • Inline variable that is immediately returned (inline-immediately-returned-variable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@SourceryAI