implement bugfix for maybe wrapping named capture groups #643
+16
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to the Nuxt Team on Vercel. A member of the Team first needs to authorize it. |
danielroe
reviewed
Dec 15, 2025
Member
danielroe
left a comment
danielroe
left a comment
There was a problem hiding this comment.
oops, looks like i missed this one.
did you mean to close it?
Author
|
I was deleting old forks and it looks like that's automatic behavior. Not sure if it's still usable/relevant but if it is feel free to re-open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #549 and potentially closes #505 as well.
The call to
wrapin the previous implementation appears to fail when the input already appears to be wrapped which occurs with named capture groups as discovered in the aforementioned issue.