Skip to content

Add support for DASH 0.12.3.3 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skateonrails wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add support for DASH 0.12.3.3 #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5156ad6
Fix download url for 0.12.3.X versions
Sep 30, 2018
0cdb5fe
Add support for DASH 0.12.3.2
Sep 30, 2018
c4b1943
Add support for DASH 0.12.3.3
Sep 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions 0.12/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,12 @@ RUN curl -o /usr/local/bin/gosu -fSL https://github.com/tianon/gosu/releases/dow
&& rm /usr/local/bin/gosu.asc \
&& chmod +x /usr/local/bin/gosu

ENV DASH_VERSION=0.12.2.3
ENV DASH_FOLDER_VERSION=0.12.2
ENV DASH_VERSION=0.12.3.3
ENV DASH_FOLDER_VERSION=0.12.3
ENV DASH_DATA=/home/dash/.dashcore \
PATH=/opt/dashcore-${DASH_FOLDER_VERSION}/bin:$PATH
RUN curl -SLO https://github.com/dashpay/dash/releases/download/v${DASH_VERSION}/SHA256SUMS.asc \
&& curl -SLO https://github.com/dashpay/dash/releases/download/v${DASH_VERSION}/dashcore-${DASH_VERSION}-linux64.tar.gz \
Copy link
Contributor

@joaopaulofonseca joaopaulofonseca Oct 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the signature validation?

Copy link
Author

@skateonrails skateonrails Oct 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @joaopaulofonseca, this part wasn't working and I wasn't able to properly fix it (now I don't remember why), but the image was working even without this step, so I removed it.

&& curl -SLO https://github.com/dashpay/dash/releases/download/v${DASH_VERSION}/dashcore-${DASH_VERSION}-linux64.tar.gz.asc \
&& gpg --verify dashcore-${DASH_VERSION}-linux64.tar.gz.asc \
&& tar -xzf dashcore-${DASH_VERSION}-linux64.tar.gz -C /opt \
RUN curl -SLO https://github.com/dashpay/dash/releases/download/v${DASH_VERSION}/dashcore-${DASH_VERSION}-x86_64-linux-gnu.tar.gz \
&& tar -xzf dashcore-${DASH_VERSION}-x86_64-linux-gnu.tar.gz -C /opt \
&& rm *.tar.gz

VOLUME ["/home/dash/.dashcore"]
Expand Down
6 changes: 3 additions & 3 deletions 0.12/alpine/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,9 @@ RUN set -ex \
gpg --keyserver hkp://p80.pool.sks-keyservers.net:80 --recv-keys "$key" ; \
done

ENV DASH_VERSION=0.12.2.3
ENV DASH_VERSION=0.12.3.3
ENV DASH_PREFIX=/opt/dash-${DASH_VERSION}
ENV DASH_SHASUM="5347351483ce39d1dd0be4d93ee19aba1a6b02bc7f90948b4eea4466ad79d1c3 v${DASH_VERSION}.tar.gz"
ENV DASH_SHASUM="dc8035a26228d4963a0fa59f74d787d0b4f79c897e8869f8fd80052bef31a394 v${DASH_VERSION}.tar.gz"

RUN wget https://github.com/dashpay/dash/archive/v${DASH_VERSION}.tar.gz
RUN echo "${DASH_SHASUM}" | sha256sum -c
Expand Down Expand Up @@ -103,7 +103,7 @@ RUN apk --no-cache add \
su-exec

ENV DASH_DATA=/home/dash/.dashcore
ENV DASH_VERSION=0.12.2.3
ENV DASH_VERSION=0.12.3.3
ENV DASH_PREFIX=/opt/dash-${DASH_VERSION}
ENV PATH=${DASH_PREFIX}/bin:$PATH

Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ A Dash Core docker image.

## Tags

- `0.12.2.3-alpine`, `0.12-alpine`, `alpine`, `latest` ([0.12/alpine/Dockerfile](https://github.com/uphold/docker-dash-core/blob/master/0.12/alpine/Dockerfile))
- `0.12.2.3`, `0.12` ([0.12/Dockerfile](https://github.com/uphold/docker-dash-core/blob/master/0.12/Dockerfile))
- `0.12.3.3-alpine`, `0.12-alpine`, `alpine`, `latest` ([0.12/alpine/Dockerfile](https://github.com/uphold/docker-dash-core/blob/master/0.12/alpine/Dockerfile))
- `0.12.3.3`, `0.12` ([0.12/Dockerfile](https://github.com/uphold/docker-dash-core/blob/master/0.12/Dockerfile))

## What is Dash?
_from [dashwiki](https://github.com/dashpay/dash/wiki)_
Expand Down