Skip to content

Conversation

@vtnate
Copy link
Contributor

@vtnate vtnate commented Jul 15, 2025

Resolves #[issue number here]

Pull Request Description

[description here]

Checklist (Delete lines that don't apply)

  • Unit tests have been added or updated
  • All ci tests pass (green)
  • This PR has been labeled appropriately (which will be used for the changelog)
  • This branch is up-to-date with develop

@vtnate vtnate self-assigned this Jul 15, 2025
@vtnate vtnate added the enhancement New feature or request label Jul 15, 2025
if feature[:properties][:capital_costs_per_square_foot] == true
building_capital_cost = feature[:properties][:capital_costs] * feature[:properties][:floor_area]
elsif feature[:properties][:capital_costs_per_square_foot] == false
building_capital_cost = feature[:properties][:capital_costs]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vtnate there might be cases when neither capital_costs or capital_costs_per_square_foot are added so we should capture that

@vtnate vtnate marked this pull request as ready for review July 28, 2025 16:52
Base automatically changed from faraday to develop October 9, 2025 17:08
lib/uo_cli.rb Outdated

opt :capital_costs, "\nCalculate simplate payback from user-provided capital costs and year-one operating costs.\n" \
'Requires REopt post-processing to have been completed first.', short: :c

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not be a separate post process call but part of existing REopt scenario post processing

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the REopt scenario file has capital cost columns, then we will run REopt optimization with capital costs.

@JingWang-CUB JingWang-CUB assigned JingWang-CUB and unassigned vtnate Oct 29, 2025
@JingWang-CUB JingWang-CUB requested a review from kflemin November 17, 2025 21:44
@JingWang-CUB
Copy link
Contributor

Hi @kflemin , @tanushree04 , this PR is ready for review. Let me know if you have any questions. Thanks!

@kflemin kflemin merged commit 7f7b984 into develop Dec 16, 2025
5 checks passed
@kflemin kflemin deleted the capital-costs-os310 branch December 16, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants