Skip to content

Conversation

@Robilol
Copy link
Contributor

@Robilol Robilol commented Jan 20, 2026

Add english translations to language selector


Summary by cubic

Add English translations to language selector labels to make choices clear for all users. Also add Romanian and clarify variants like Traditional and Simplified Chinese.

Written for commit 4dc1f78. Summary will update on new commits.

Summary by CodeRabbit

  • Improvements
    • Language selector now displays both native and English names for clarity (e.g., Italiano (Italian), Français (French), Deutsch (German), 正體中文 (Traditional Chinese), 简体中文 (Simplified Chinese), Українська (Ukrainian)).
    • Romanian added to the language list (Română).

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 20, 2026

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

📝 Walkthrough

Walkthrough

This change updates the display strings in the SUPPORTED_LANGUAGES map in app/src/main/java/app/gamenative/utils/LocaleHelper.kt: six existing language labels were expanded to include English names and a new ro (Romanian) entry was added.

Changes

Cohort / File(s) Summary
Locale mapping updates
app/src/main/java/app/gamenative/utils/LocaleHelper.kt
Updated display names: it → "Italiano (Italian)", uk → "Українська (Ukrainian)", zh-TW → "正體中文 (Traditional Chinese)", zh-CN → "简体中文 (Simplified Chinese)", fr → "Français (French)", de → "Deutsch (German)"; added ro → "Română (Romanian)".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

Possibly related PRs

Poem

🐰✨ I hopped through maps of tongue and tone,
Gave names both native and English known.
Italiano, Українська, 中文 in view,
Deutsch and Français now clearer too.
Română bounced in — hello, new crew!

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title 'Language selector english translations' partially aligns with the changeset but is misleading. The actual changes include adding English translations to language labels, adding Romanian support, and clarifying Chinese locale variants—not just English translations to the selector itself. Consider a more accurate title like 'Add English translations and Romanian support to language selector' to better represent all key changes in the pull request.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@app/src/main/java/app/gamenative/utils/LocaleHelper.kt`:
- Line 24: The line containing the map entry `"uk" to "Українська (Ukrainian)"`
in LocaleHelper.kt uses a TAB for indentation; replace that TAB with the same
number of spaces used elsewhere in the file to match existing indentation style
(e.g., convert the leading TAB to spaces so the mapping aligns with other
entries in the locale map).

"zh-CN" to "简体中文",
"fr" to "Français",
"de" to "Deutsch"
"uk" to "Українська (Ukrainian)",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Inconsistent indentation: TAB used instead of spaces.

Line 24 uses a TAB character for indentation while the rest of the file uses spaces. This should be fixed for consistency.

🔧 Suggested fix
-		"uk" to "Українська (Ukrainian)",
+        "uk" to "Українська (Ukrainian)",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"uk" to "Українська (Ukrainian)",
"uk" to "Українська (Ukrainian)",
🤖 Prompt for AI Agents
In `@app/src/main/java/app/gamenative/utils/LocaleHelper.kt` at line 24, The line
containing the map entry `"uk" to "Українська (Ukrainian)"` in LocaleHelper.kt
uses a TAB for indentation; replace that TAB with the same number of spaces used
elsewhere in the file to match existing indentation style (e.g., convert the
leading TAB to spaces so the mapping aligns with other entries in the locale
map).

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="app/src/main/java/app/gamenative/utils/LocaleHelper.kt">

<violation number="1" location="app/src/main/java/app/gamenative/utils/LocaleHelper.kt:29">
P3: "Romenian" is misspelled; the correct English name is "Romanian".</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Fix all issues with AI agents
In `@app/src/main/java/app/gamenative/utils/LocaleHelper.kt`:
- Around line 28-29: The map literal in LocaleHelper (the LANGUAGE_DISPLAY_NAMES
/ language map in LocaleHelper.kt) has a missing comma between the entries `"de"
to "Deutsch (German)"` and `"ro" to "Română (Romenian)"`; add a comma after the
`"Deutsch (German)"` entry so the map entries are properly separated and the
file compiles.
- Line 29: The locale map in LocaleHelper.kt has a syntax error and a
misspelling: add the missing comma after the "de" entry (the line with "de" to
"Deutsch (German)") and correct the Romanian label from "Romenian" to "Romanian"
(the line with "ro" to "Română (Romanian)"); update the entries in the locale
map where these keys/values are defined to ensure the map compiles and the label
is spelled correctly.

@Robilol Robilol force-pushed the feat/language-selector-translation branch from f320012 to 4dc1f78 Compare January 20, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant