feat(i18n): add Spanish localization support #434
Conversation
- Add Spanish translations in `values-es/strings.xml` - Register 'es' locale in `LocaleHelper.kt` - Update `build.gradle.kts` to include the Spanish resource configuration
- Correct technical terminology (e.g., "Wrapper", "CSMT", "case-insensitive").
- Improve context accuracy for Library layouts and filters (e.g., "Source", "View").
- Standardize dialog titles to be affirmative and move questions to the message body.
- Fix specific UI strings for Custom Games, GOG, and Emulation settings for better natural flow.
- Consistency fixes for trust-related messages ("de confianza").
📝 WalkthroughWalkthroughThis PR adds Spanish localization support to the application by registering the "es" locale in the Gradle build configuration, appending a Spanish language entry to the SUPPORTED_LANGUAGES mapping in LocaleHelper, and introducing a comprehensive Spanish translation resource file containing UI strings across all app features and dialogs. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@app/src/main/res/values-es/strings.xml`:
- Around line 352-357: The CDATA content for string "box86_64_env_var_help__avx"
contains a trailing backslash before the closing tag which can break HTML
rendering; remove the stray "\" at the end of the third line inside the CDATA
block so the HTML fragment ends cleanly and verify the translated text still
uses proper HTML entities and line breaks.
🧹 Nitpick comments (1)
app/src/main/res/values-es/strings.xml (1)
161-162: Consider clarifying the exit strings.Lines 161-162 have two exit-related strings with similar translations that might confuse users:
exit_game→ "Salir" (Exit)exit→ "Salir del juego" (Exit the game)The naming suggests
exit_gameshould be "Exit game" andexitshould be the generic "Exit", but the translations are swapped. Verify the intended usage context matches the English source strings.
| <string name="box86_64_env_var_help__avx"><![CDATA[ | ||
| ¡AVX y AVX2 implementados, junto con las extensiones BMI1, BMI2, ADX, FMA, F16C y RDANDR!<br /><br /> | ||
| <b>0</b> : Deshabilitar extensión AVX<br /> | ||
| <b>1</b> : Habilitar extensiones AVX, BMI1, F16C y VAES.<br /> | ||
| <b>2</b> : Todo el punto 1 más habilitar AVX2, BMI2, FMA, ADX, VPCLMULQDQ y RDRAND.<br />\ | ||
| ]]></string> |
There was a problem hiding this comment.
Trailing backslash may cause rendering issues.
Line 356 has a trailing \ before the closing tag that may cause unexpected behavior when rendering the HTML content.
Suggested fix
- <b>2</b> : Todo el punto 1 más habilitar AVX2, BMI2, FMA, ADX, VPCLMULQDQ y RDRAND.<br />\
+ <b>2</b> : Todo el punto 1 más habilitar AVX2, BMI2, FMA, ADX, VPCLMULQDQ y RDRAND.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <string name="box86_64_env_var_help__avx"><![CDATA[ | |
| ¡AVX y AVX2 implementados, junto con las extensiones BMI1, BMI2, ADX, FMA, F16C y RDANDR!<br /><br /> | |
| <b>0</b> : Deshabilitar extensión AVX<br /> | |
| <b>1</b> : Habilitar extensiones AVX, BMI1, F16C y VAES.<br /> | |
| <b>2</b> : Todo el punto 1 más habilitar AVX2, BMI2, FMA, ADX, VPCLMULQDQ y RDRAND.<br />\ | |
| ]]></string> | |
| <string name="box86_64_env_var_help__avx"><![CDATA[ | |
| ¡AVX y AVX2 implementados, junto con las extensiones BMI1, BMI2, ADX, FMA, F16C y RDANDR!<br /><br /> | |
| <b>0</b> : Deshabilitar extensión AVX<br /> | |
| <b>1</b> : Habilitar extensiones AVX, BMI1, F16C y VAES.<br /> | |
| <b>2</b> : Todo el punto 1 más habilitar AVX2, BMI2, FMA, ADX, VPCLMULQDQ y RDRAND.<br /> | |
| ]]></string> |
🤖 Prompt for AI Agents
In `@app/src/main/res/values-es/strings.xml` around lines 352 - 357, The CDATA
content for string "box86_64_env_var_help__avx" contains a trailing backslash
before the closing tag which can break HTML rendering; remove the stray "\" at
the end of the third line inside the CDATA block so the HTML fragment ends
cleanly and verify the translated text still uses proper HTML entities and line
breaks.
|
Regarding the issues flagged by the bot and the nitpick about the exit strings: I checked the original source file at 1. Regarding the <string name="exit_game">Exit</string>
<string name="exit">Exit Game</string>2. Regarding the trailing backslash in <string name="box86_64_env_var_help__avx"><![CDATA[
AVX and AVX2 implemented, along with BMI1, BMI2, ADX, FMA, F16C and RDANDR extension!<br /><br />
<b>0</b> : Disable AVX extension<br />
<b>1</b> : enable AVX, BMI1, F16C and VAES extension.<br />
<b>2</b> : All 1 plus enable AVX2, BMI2, FMA, ADX,VPCLMULQDQ and RDRAND.<br />\
]]></string>Could a maintainer please confirm how to proceed? |
1 participant
This PR introduces full Spanish language support to GameNative. It includes the translation resources, code registration, and build configuration updates.
Changes
app/src/main/res/values-es/strings.xml.eslocale inLocaleHelper.kt.build.gradle.ktsto include Spanish resource configuration.Summary by cubic
Adds full Spanish localization to GameNative. Users can now select Español and see the app translated across login, library, settings, and dialogs.
New Features
Bug Fixes
Written for commit cd3866f. Summary will update on new commits.
Summary by CodeRabbit
New Features
✏️ Tip: You can customize this high-level summary in your review settings.