Skip to content

Conversation

@lohanidamodar
Copy link
Contributor

@lohanidamodar lohanidamodar commented Nov 26, 2025

  • replace assertEquals with assertSame

Summary by CodeRabbit

  • Tests
    • Strengthened test assertion strictness across domain, registrar, and validator test suites. Test assertions now enforce strict type-equality verification for improved reliability during development cycles.

✏️ Tip: You can customize this high-level summary in your review settings.

- replace assertEquals with assertSame
@coderabbitai
Copy link

coderabbitai bot commented Nov 26, 2025

Walkthrough

This pull request systematically upgrades PHPUnit assertions across three test files, replacing assertEquals with assertSame to enforce strict type and value equivalence. Changes are applied consistently across DomainTest.php (190 lines), OpenSRSTest.php (5 lines), and PublicDomainTest.php (23 lines), affecting numerous test methods for domain validation, registry operations, and public domain checks. No functional behavior or public entity declarations are altered.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Refactor: assertions' accurately describes the main change: replacing assertEquals with assertSame across test files for stricter type checking.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lohanidamodar lohanidamodar merged commit afd7e78 into master Jan 27, 2026
7 checks passed
@lohanidamodar lohanidamodar deleted the refactor-assertions branch January 27, 2026 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants