feat: add PR code generation validation workflow #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add automated code generation check for pull requests to validate proto file changes and ensure code generation succeeds before merge. This addresses GitHub issue #172 by: - Running buf code generation on every PR targeting main - Validating generation for all supported languages (Rust, Node, Go, Python, .NET, Haskell) - Reusing existing generate.yml workflow for consistency - Including concurrency control to cancel outdated runs - Uploading generated code as artifact for inspection The workflow triggers on PR open, synchronize, and reopen events, providing early feedback to contributors about generation issues. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Extend PR code generation check to include full publish dry-run validation for all language packages, catching additional issues: - Package structure validation (Cargo.toml, package.json, etc.) - TypeScript transpilation for Node packages - Dependency resolution for all languages - Package metadata and version validation - Publishing readiness checks This now matches the dry-run.yml workflow pattern and provides comprehensive validation as originally requested in issue #172. Changes: - Add publish-dry-run job that depends on codegen - Run publish-all.yml in dry-run mode for all languages - Validate Rust, Node, Go, Python, .NET, and Haskell packages - Inherit secrets for package registry authentication 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
scarmuega
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds automated code generation and package validation for pull requests to catch proto definition, generation, and packaging issues before merge.
Changes
.github/workflows/pr-check.ymlthat triggers on PRs targetingmaingenerate.ymlandpublish-all.ymlworkflows for consistencyValidation Performed
Code Generation:
Package Validation (dry-run):
cargo publish --dry-runvalidates crate structure and dependenciesnpm publish --dry-runvalidates packageBenefits
Related Issues
Closes #172
🤖 Generated with Claude Code