feat: add client-side dynamic theme switching for dev pages #10788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace server-side theme injection with client-side theme switching, eliminating the need to restart the dev server when changing themes. Changes: - Add theme switcher UI with fixed-position buttons (Base/Lumo/Aura) - Support URL parameters (?theme=base|lumo|aura) for shareable links - Add browser back/forward navigation support - Remove start:lumo and start:aura npm commands - Remove server-side theme injection from web-dev-server.config.js Benefits: - Instant theme switching without page reload - Shareable URLs with specific themes - Simple URL-only state (no localStorage complexity) - Full accessibility (ARIA labels, keyboard navigation)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace server-side theme injection with client-side theme switching, eliminating the need to restart the dev server when changing themes.
Changes: