-
Notifications
You must be signed in to change notification settings - Fork 64
mbp-1020: Add UC02 Secure Supply Chain to layered-zero-trust #627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@mlorenzofr: This pull request references mbp-1020 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hi @mlorenzofr. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need minor language updates. [@gaurav-nelson to fix]
content/patterns/layered-zero-trust/lzt-secure-supply-chain.adoc
Outdated
Show resolved
Hide resolved
content/patterns/layered-zero-trust/lzt-secure-supply-chain.adoc
Outdated
Show resolved
Hide resolved
content/patterns/layered-zero-trust/lzt-secure-supply-chain.adoc
Outdated
Show resolved
Hide resolved
content/patterns/layered-zero-trust/lzt-secure-supply-chain.adoc
Outdated
Show resolved
Hide resolved
content/patterns/layered-zero-trust/lzt-secure-supply-chain.adoc
Outdated
Show resolved
Hide resolved
content/patterns/layered-zero-trust/lzt-secure-supply-chain.adoc
Outdated
Show resolved
Hide resolved
content/patterns/layered-zero-trust/lzt-secure-supply-chain.adoc
Outdated
Show resolved
Hide resolved
content/patterns/layered-zero-trust/lzt-secure-supply-chain.adoc
Outdated
Show resolved
Hide resolved
content/patterns/layered-zero-trust/lzt-secure-supply-chain.adoc
Outdated
Show resolved
Hide resolved
content/patterns/layered-zero-trust/lzt-secure-supply-chain.adoc
Outdated
Show resolved
Hide resolved
|
@mlorenzofr I'll fix the minor language issue once I get the technical approval from other reviewers. |
sabre1041
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good. A number of comments, suggestions and recommendations
content/patterns/layered-zero-trust/lzt-secure-supply-chain.adoc
Outdated
Show resolved
Hide resolved
content/patterns/layered-zero-trust/lzt-secure-supply-chain.adoc
Outdated
Show resolved
Hide resolved
| + | ||
| [source,terminal] | ||
| ---- | ||
| # Sign the image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we obtain a fresh OIDC token from Keycloak? The token that I obtained originally expired during my testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know, the OIDC token expiration depends on how long the user takes to run the tasks, or the environment in which they run them. It's difficult to say whether that will happen in this step or any other.
If the error isn't too cryptic, I think we could rely on the user's expertise to figure out what's happening and generate a new one, the instructions are already in the documentation.
If necessary, I would add a warning to the token generation step explaining that this step may be required several times throughout the process.
content/patterns/layered-zero-trust/lzt-secure-supply-chain.adoc
Outdated
Show resolved
Hide resolved
|
@sabre1041: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Co-authored-by: Gaurav Nelson <23069445+gaurav-nelson@users.noreply.github.com>
Co-authored-by: Gaurav Nelson <23069445+gaurav-nelson@users.noreply.github.com>
Co-authored-by: Gaurav Nelson <23069445+gaurav-nelson@users.noreply.github.com>
Co-authored-by: Gaurav Nelson <23069445+gaurav-nelson@users.noreply.github.com>
Co-authored-by: Gaurav Nelson <23069445+gaurav-nelson@users.noreply.github.com>
Co-authored-by: Gaurav Nelson <23069445+gaurav-nelson@users.noreply.github.com>
Co-authored-by: Gaurav Nelson <23069445+gaurav-nelson@users.noreply.github.com>
Co-authored-by: Gaurav Nelson <23069445+gaurav-nelson@users.noreply.github.com>
Co-authored-by: Gaurav Nelson <23069445+gaurav-nelson@users.noreply.github.com>
Co-authored-by: Gaurav Nelson <23069445+gaurav-nelson@users.noreply.github.com>
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Andrew Block <andy.block@gmail.com>
Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com>
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Andrew Block <andy.block@gmail.com>
Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com>
Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com>
Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com>
Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com>
Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com>
Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com>
|
@mlorenzofr: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR adds documentation for Use Case 2 (Supply Chain) of the
layered-zero-trust(ZTVP) pattern