Skip to content

Conversation

@mlorenzofr
Copy link

This PR adds documentation for Use Case 2 (Supply Chain) of the layered-zero-trust (ZTVP) pattern

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 8, 2025

@mlorenzofr: This pull request references mbp-1020 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set.

Details

In response to this:

This PR adds documentation for Use Case 2 (Supply Chain) of the layered-zero-trust (ZTVP) pattern

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 8, 2025

Hi @mlorenzofr. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the size/L label Dec 8, 2025
@gaurav-nelson gaurav-nelson self-assigned this Dec 8, 2025
@gaurav-nelson
Copy link
Collaborator

/ok-to-test

Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com>
Copy link
Collaborator

@gaurav-nelson gaurav-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need minor language updates. [@gaurav-nelson to fix]

@gaurav-nelson
Copy link
Collaborator

@mlorenzofr I'll fix the minor language issue once I get the technical approval from other reviewers.

Copy link

@sabre1041 sabre1041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good. A number of comments, suggestions and recommendations

+
[source,terminal]
----
# Sign the image

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we obtain a fresh OIDC token from Keycloak? The token that I obtained originally expired during my testing

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, the OIDC token expiration depends on how long the user takes to run the tasks, or the environment in which they run them. It's difficult to say whether that will happen in this step or any other.

If the error isn't too cryptic, I think we could rely on the user's expertise to figure out what's happening and generate a new one, the instructions are already in the documentation.

If necessary, I would add a warning to the token generation step explaining that this step may be required several times throughout the process.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 11, 2025

@sabre1041: changing LGTM is restricted to collaborators

Details

In response to this:

Looking really good. A number of comments, suggestions and recommendations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

mlorenzofr and others added 11 commits December 11, 2025 15:21
Co-authored-by: Gaurav Nelson <23069445+gaurav-nelson@users.noreply.github.com>
Co-authored-by: Gaurav Nelson <23069445+gaurav-nelson@users.noreply.github.com>
Co-authored-by: Gaurav Nelson <23069445+gaurav-nelson@users.noreply.github.com>
Co-authored-by: Gaurav Nelson <23069445+gaurav-nelson@users.noreply.github.com>
Co-authored-by: Gaurav Nelson <23069445+gaurav-nelson@users.noreply.github.com>
Co-authored-by: Gaurav Nelson <23069445+gaurav-nelson@users.noreply.github.com>
Co-authored-by: Gaurav Nelson <23069445+gaurav-nelson@users.noreply.github.com>
Co-authored-by: Gaurav Nelson <23069445+gaurav-nelson@users.noreply.github.com>
Co-authored-by: Gaurav Nelson <23069445+gaurav-nelson@users.noreply.github.com>
Co-authored-by: Gaurav Nelson <23069445+gaurav-nelson@users.noreply.github.com>
Co-authored-by: Andrew Block <andy.block@gmail.com>
mlorenzofr and others added 26 commits December 11, 2025 15:23
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Andrew Block <andy.block@gmail.com>
Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com>
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Andrew Block <andy.block@gmail.com>
Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com>
Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com>
Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com>
Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com>
Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com>
Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 11, 2025

@mlorenzofr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/build-preview 267592b link true /test build-preview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants