Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<parent>
<groupId>dev.vality</groupId>
<artifactId>service-parent-pom</artifactId>
<version>3.1.0</version>
<version>3.1.6</version>
</parent>

<name>fraudbusters</name>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,18 +17,14 @@ public class PayerFieldExtractor {
public static Optional<ContactInfo> getContactInfo(Payer payer) {
if (payer.isSetPaymentResource()) {
return Optional.ofNullable(payer.getPaymentResource().getContactInfo());
} else if (payer.isSetCustomer()) {
return Optional.ofNullable(payer.getCustomer().getContactInfo());
} else if (payer.isSetRecurrent()) {
return Optional.ofNullable(payer.getRecurrent().getContactInfo());
}
return Optional.empty();
}

public static Optional<BankCard> getBankCard(Payer payer) {
if (payer.isSetCustomer() && payer.getCustomer().getPaymentTool().isSetBankCard()) {
return Optional.ofNullable(payer.getCustomer().getPaymentTool().getBankCard());
} else if (payer.isSetPaymentResource()
if (payer.isSetPaymentResource()
&& payer.getPaymentResource().getResource().getPaymentTool().isSetBankCard()) {
return Optional.ofNullable(payer.getPaymentResource().getResource().getPaymentTool().getBankCard());
} else if (payer.isSetRecurrent() && payer.getRecurrent().getPaymentTool().isSetBankCard()) {
Expand All @@ -49,8 +45,6 @@ public static String getPayerType(Payer payer) {
return PayerType.PAYMENT_RESOURCE.name();
} else if (payer.isSetRecurrent()) {
return PayerType.RECURRENT.name();
} else if (payer.isSetCustomer()) {
return PayerType.CUSTOMER.name();
} else {
return ClickhouseUtilsValue.UNKNOWN;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
public class PaymentTypeByContextResolver {

public boolean isRecurrent(Payer payer) {
return payer.isSetRecurrent() || payer.isSetCustomer();
return payer.isSetRecurrent();
}

public boolean isMobile(BankCard bankCard) {
Expand Down
11 changes: 6 additions & 5 deletions src/test/java/dev/vality/fraudbusters/util/BeanUtil.java
Original file line number Diff line number Diff line change
Expand Up @@ -56,16 +56,17 @@ public static Context createContext(String paymentId) {
new Shop(
ID_VALUE_SHOP,
new Category("pizza", "no category"),
new ShopDetails("pizza-sushi"),
"pizza-sushi",
location
),
new InvoicePayment(
paymentId,
TypeUtil.temporalToString(Instant.now()),
Payer.customer(
new CustomerPayer("custId", "1", "rec_paym_tool", createPaymentTool(),
contactInfo
)),
Payer.payment_resource(new PaymentResourcePayer()
.setResource(new DisposablePaymentResource()
.setPaymentTool(createPaymentTool()))
.setContactInfo(new ContactInfo()
.setEmail("test@test"))),
new Cash(
9000L,
new CurrencyRef("RUB")
Expand Down
Loading