Fix PHP 8.4 deprecation warning #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implicitly nullable parameters (i.e. those accepting null without a null typehint) are deprecated in PHP 8.4. Marking `$library` as explicitly nullable fixes the following deprecation warning: > Deprecated: Nbbc\BBCode::__construct(): Implicitly marking parameter > $library as nullable is deprecated, the explicit nullable type must be > used instead Explicitly nullable types were not added until PHP 7.1, so the minimum requirement is raised from 5.6 (which reached EOL in 2017) to 7.1 (which was released in 2016). Documentation has been updated accordingly. Added PHP 8.3 and 8.4 to the GitHub Actions test matrix.
hemberger
added a commit
to hemberger/smr
that referenced
this pull request
May 11, 2025
The vanilla/nbbc code has a deprecation warning that will be fixed with the following PR: vanilla/nbbc#39 While we wait for that to be merged, install from the PR branch to avoid the deprecation warning. Added a test of the `bbify` function, since there was previously no test code exercising nbbc. Also pass the `smrBBCode` function as a first- class callable when creating BBCode rules.
hemberger
added a commit
to smrealms/smr
that referenced
this pull request
May 11, 2025
The vanilla/nbbc code has a deprecation warning that will be fixed with the following PR: vanilla/nbbc#39 While we wait for that to be merged, install from the PR branch to avoid the deprecation warning. Added a test of the `bbify` function, since there was previously no test code exercising nbbc. Also pass the `smrBBCode` function as a first- class callable when creating BBCode rules.
Author
|
@acharron-hl Hi! You've helped me merge my PRs in the past, and I was wondering if you might be able to take a quick look at this. Thanks! |
acharron-hl
approved these changes
Sep 16, 2025
|
Sorry for the delay, glad you mentioned me. We would have run into this relatively soon ourselves in any case, but thanks for the PR. I'll merge it and tag a new release. |
Author
Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implicitly nullable parameters (i.e. those accepting null without a null typehint) are deprecated in PHP 8.4. Marking
$libraryas explicitly nullable fixes the following deprecation warning:Explicitly nullable types were not added until PHP 7.1, so the minimum requirement is raised from 5.6 (which reached EOL in 2017) to 7.1 (which was released in 2016). Documentation has been updated accordingly.
Added PHP 8.3 and 8.4 to the GitHub Actions test matrix.