-
Notifications
You must be signed in to change notification settings - Fork 0
feat(allProject): add mvvm, network services #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vaskhan
wants to merge
3
commits into
main
Choose a base branch
from
sprint_21
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
ScheduleTracker.xcodeproj/project.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
| <plist version="1.0"> | ||
| <dict/> | ||
| </plist> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| // | ||
| // AppErrorType.swift | ||
| // ScheduleTracker | ||
| // | ||
| // Created by Василий Ханин on 24.07.2025. | ||
| // | ||
|
|
||
|
|
||
| import Foundation | ||
|
|
||
| enum AppErrorType { | ||
| case none | ||
| case server | ||
| case internet | ||
| } | ||
|
|
||
| @MainActor | ||
| protocol ErrorHandleable: ObservableObject { | ||
| var errorType: AppErrorType { get set } | ||
| } | ||
|
|
||
| extension ErrorHandleable { | ||
| func handle(error: Error) { | ||
| if let urlError = error as? URLError { | ||
| switch urlError.code { | ||
| case .notConnectedToInternet: | ||
| errorType = .internet | ||
| default: | ||
| errorType = .server | ||
| } | ||
| } else { | ||
| errorType = .server | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| // | ||
| // StateWrapperView.swift | ||
| // ScheduleTracker | ||
| // | ||
| // Created by Василий Ханин on 25.07.2025. | ||
| // | ||
| import SwiftUI | ||
|
|
||
| struct StateWrapperView<Content: View>: View { | ||
| let isLoading: Bool | ||
| let errorType: AppErrorType? | ||
| let content: () -> Content | ||
|
|
||
| var body: some View { | ||
| Group { | ||
| if isLoading { | ||
| VStack { | ||
| Spacer() | ||
| ProgressView() | ||
| Spacer() | ||
| } | ||
| } else if errorType == .internet { | ||
| ErrorInternetView() | ||
| } else if errorType == .server { | ||
| ErrorServerView() | ||
| } else { | ||
| content() | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| // | ||
| // CarrierInfoModel.swift | ||
| // ScheduleTracker | ||
| // | ||
| // Created by Василий Ханин on 24.07.2025. | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| struct CarrierInfoModel: Identifiable, Sendable { | ||
| var id: Int { code } | ||
| let code: Int | ||
| let title: String | ||
| let logo: String? | ||
| let email: String? | ||
| let phone: String? | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| // | ||
| // StationModel.swift | ||
| // ScheduleTracker | ||
| // | ||
| // Created by Василий Ханин on 23.07.2025. | ||
| // | ||
| import Foundation | ||
|
|
||
| struct StationModel: Identifiable, Sendable { | ||
| let id: String | ||
| let title: String | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| // | ||
| // CarrierInfoViewModel.swift | ||
| // ScheduleTracker | ||
| // | ||
| // Created by Василий Ханин on 24.07.2025. | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| @MainActor | ||
| final class CarrierInfoViewModel: ObservableObject, ErrorHandleable { | ||
| @Published var carrier: CarrierInfoModel? | ||
| @Published var isLoading = false | ||
| @Published var errorMessage: String? | ||
| @Published var errorType: AppErrorType = .none | ||
|
|
||
| private let service: CarrierServiceProtocol | ||
|
|
||
| init(service: CarrierServiceProtocol) { | ||
| self.service = service | ||
| } | ||
|
|
||
| func fetchCarrier(code: String) async { | ||
| isLoading = true | ||
| errorType = .none | ||
| do { | ||
| let response = try await service.getCarrierInfo(code: code) | ||
| guard let carrier = response.carrier else { | ||
| errorMessage = "Не найдено информации о перевозчике" | ||
| isLoading = false | ||
| return | ||
| } | ||
| self.carrier = CarrierInfoModel( | ||
| code: carrier.code ?? 0, | ||
| title: carrier.title ?? "—", | ||
| logo: carrier.logo, | ||
| email: carrier.email, | ||
| phone: carrier.phone | ||
| ) | ||
| } catch { | ||
| self.handle(error: error) | ||
| } | ||
| isLoading = false | ||
| } | ||
| } | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
По своему опыту хотел бы отметить, что в продакшене не используют
fatalError, советую заменить наassertionFailure, тут подробнее