fix: use mental model text field in reflect based_on response #206
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auto-consolidated mental models have a `text` field but no `name` or
`summary`. The old code always constructed text as `f"{name}: {summary}"`
which produced `": "` for these models. Now uses the `text` field when
available, falling back to name/summary construction for backwards
compatibility with older model formats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
textfield but nonameorsummary. The old code always constructed text asf"{name}: {summary}"which produced": "for these models.textfield when available, falling back to name/summary construction for backwards compatibility with older model formats.get_mental_modelandsearch_mental_modelscode paths in the reflect response builder.Test plan
based_on.mental-modelsentries have correct text (not": ")