Skip to content

Conversation

@jaameemoo
Copy link

This updates the Jekyll just-the-docs theme, switches the Docker base image, removes the (unused?) jekyll-feed dependency and removes some boilerplate.

Commits should probably be squashed, since I didn't succeed at keeping the project building during the migration.

@jaameemoo jaameemoo requested a review from mielvds December 16, 2025 11:53
gem "just-the-docs", github: "pdmosses/just-the-docs", branch: "combination-rec-nav"
# If you want to use GitHub Pages, remove the "gem "jekyll"" above and
# uncomment the line below. To upgrade, run `bundle update github-pages`.
gem "github-pages", group: :jekyll_plugins
Copy link
Collaborator

@mielvds mielvds Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these were necessary to get the correct build, because legacy github pages build (which is what we currently use) only supports certain versions of jekyll. If you want to upgrade to jekyll 4.4, you have to switch to github actions (I think)

Have you tested this on github pages?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this was only tested locally! Will look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants