Cleanup .golangci.yml

[timvaillancourt]

Description

This PR performs further cleanup of .golangci.yml, specifically:

1. Un-disable staticcheck quick-fix QF1008 + apply auto-fixes
   • golangci-lint run --fix ./go/... applied this 🪄
2. Remove disabled govet checks
   • This caused no/zero new failures ✅
3. Remove old code path references for deleted code

Related Issue(s)

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

Deployment Notes

AI Disclosure

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[codecov]

Codecov Report

❌ Patch coverage is 82.83262% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.77%. Comparing base (1f49de4) to head (7e56e47).
⚠️ Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
go/cmd/vtctldclient/cli/shards.go	0.00%	4 Missing ⚠️
go/vt/binlog/binlog_connection.go	25.00%	3 Missing ⚠️
go/vt/vttablet/tabletmanager/rpc_replication.go	25.00%	3 Missing ⚠️
go/vt/vttablet/tabletmanager/vdiff/table_differ.go	0.00%	3 Missing ⚠️
go/mysql/collations/colldata/8bit.go	50.00%	2 Missing ⚠️
go/mysql/ldapauthserver/auth_server_ldap.go	71.42%	2 Missing ⚠️
go/vt/topo/test/tablet.go	66.66%	2 Missing ⚠️
go/vt/wrangler/switcher_dry_run.go	0.00%	2 Missing ⚠️
go/cmd/vtbackup/cli/vtbackup.go	0.00%	1 Missing ⚠️
go/cmd/vtctldclient/command/shards.go	0.00%	1 Missing ⚠️
... and 17 more

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #18929   +/-   ##
=======================================
  Coverage   69.77%   69.77%           
=======================================
  Files        1608     1608           
  Lines      214908   214933   +25     
=======================================
+ Hits       149953   149973   +20     
- Misses      64955    64960    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.