Add nested property access support to Visual Editor #1196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Visual Editor failed to display widgets for nested config properties (e.g.,
margin.left) despite README documentation indicating support. The underlying utility functions didn't handle dot notation paths.Changes
Nested Property Utilities (
utils.ts)getNestedProperty<T>()andsetNestedProperty<T>()with TypeScript generics..), leading/trailing dots__proto__,constructor,prototypekeys== nullinstead of falsy checks to preserve0,false, empty stringsVisualEditor Component
min, checkboxes→false, text→"", dropdowns→first option, colors→#000000Test Configuration
"Point Radius"→"pointRadius""margin.left"widget demonstrating nested accessExample
Security: CodeQL scan passes with 0 alerts.
Original prompt
This section details on the original issue you should resolve
<issue_title>Broken Visual Editor</issue_title>
<issue_description>This does not show the visual editor, but should:
asyncRequest.js
renderLoadingState.js
renderMarks.js
styles.css
iris.csv
scatterPlot.js
index.js
loadAndParseData.js
config.json
setupSVG.js
index.html
viz.js