Skip to content

Conversation

@dkwo
Copy link

@dkwo dkwo commented Mar 1, 2023

this allows to use alternative device manager as in void-linux/void-packages#42488

@Duncaen
Copy link
Member

Duncaen commented Mar 2, 2023

Not a fan of this, udev is the default and I don't think we would support any other setup. You can uninstall udevd and drop in your own file if required.

@Vaelatern
Copy link
Member

Vaelatern commented Mar 2, 2023

Would agree with duncaen, one point of having these files in a directory instead of being a single file is so you can make these changes on your own system (or with automation) in a safe way.

@dkwo
Copy link
Author

dkwo commented Mar 3, 2023

What you say makes sense. However, one advantage of the small modification I propose is that it kills the device manager at the end of stage 1 (if you do not start the corresponding service with runit, that it is left running currently). I also tested it and it seems to work fine.

@dkwo dkwo changed the title core-services/{02,99},rc.conf allow alternative udev allow alternative udev Mar 20, 2023
@xplshn
Copy link

xplshn commented Apr 16, 2024

I don't see what the problem would be, none of the changes break udev, and they allow for more flexibility. And this benefits both udev and libudev-zero users

Copy link

@vincele vincele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

_udevd=udevd
else
msg_warn "cannot find udevd!"
fi
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume loosing this systemd-specific file name and path is OK (not that I really personally care)

# The device manager to run during the init process. This is killed once boot
# is complete for a supervised version to take its place. Valid values are
# currently 'mdevd' or 'udevd' (default).
CONFIG_DEV=udevd
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd change the variable name to CONFIG_DEVD, or something like that, as I think the _DEV suffix would imply a device. But that's bikeshedding, feel free to ignore.

@Duncaen
Copy link
Member

Duncaen commented Jun 14, 2024

We have better things to do than having to maintain compatibility for udev alternatives for 3 users.

The way it works now, udev is optional and you can just drop in your own script. I don't see a reason to make this an option in the official scripts while we only officially support udev.

@dkwo dkwo closed this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants