Skip to content

Conversation

@alessandrobellesia
Copy link
Member

[0.0.3] - 2025-12-03

Changed

  • BREAKING: DailyClosure type structure completely rewritten to match actual Satispay API response
    • Now returns shop_daily_closure and device_daily_closure objects
    • Each closure includes: id, type, customer_uid, gross_amount_unit, refund_amount_unit, amount_unit, currency
  • BREAKING: Removed non-existent fields from DailyClosure type:
    • Removed date field (use shop_daily_closure.id instead)
    • Removed total_amount_unit field (use shop_daily_closure.amount_unit instead)
    • Removed payments_count field (not provided by Satispay API)
  • DailyClosure.get() now accepts Date objects in addition to string dates (YYYYMMDD format)
  • Updated documentation with correct API response structure and Date object usage examples

Added

  • DailyClosureDetail type for structured closure information
  • DateUtils.formatToYYYYMMDD() utility function for date formatting
  • Comprehensive E2E tests for daily closure functionality (5 test cases)
  • Unit tests for Date object support in DailyClosure.get()
  • Enhanced examples showing multiple ways to retrieve daily closures

Fixed

  • DailyClosure type now accurately reflects Satispay's actual API response
  • Corrected documentation to match real API behavior verified through testing

Alessandro Bellesia and others added 2 commits December 3, 2025 19:40
fix(daily-closure)!: align DailyClosure type with actual API response

BREAKING CHANGE: DailyClosure type now matches real API with shop_daily_closure and device_daily_closure objects. Removed incorrect payments_count field. Added Date object support to get() method.
@coderabbitai
Copy link

coderabbitai bot commented Dec 3, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 3, 2025

@alessandrobellesia alessandrobellesia merged commit 1cca2aa into main Dec 3, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants