Skip to content

Conversation

@neutrinoceros
Copy link
Contributor

based off #672

@neutrinoceros
Copy link
Contributor Author

neutrinoceros commented Aug 1, 2025

no problems here. This should be undrafted once #672 is merged

@neutrinoceros
Copy link
Contributor Author

Actually I would still recommend to wait a bit to merge this one:

  • resources to run the test suite are limited and this increases demand. Given how long the full suite is to run and how many PRs I'd like to get going, merging this one early could slow down the whole process significantly
  • no errors so far, but warnings are not being treated as errors yet, so there might still be deprecation warning slipping in, and it'd be best to solve them here

@neutrinoceros neutrinoceros force-pushed the tst/cp311-313 branch 3 times, most recently from f0f45a5 to c39be87 Compare August 15, 2025 21:29
@IainHammond
Copy link
Contributor

Looks good to me! Just needs the readme to be updated on line 9 I assume? Something like this: https://img.shields.io/badge/Python-3.10%2C%203.11%2C%203.12%2C%203.13-brightgreen.svg

@neutrinoceros
Copy link
Contributor Author

good catch. Done

@neutrinoceros neutrinoceros marked this pull request as ready for review August 19, 2025 17:28
@VChristiaens VChristiaens merged commit d0a59c9 into vortex-exoplanet:master Aug 22, 2025
14 checks passed
@VChristiaens
Copy link
Contributor

Thanks a lot! This looks good to me.

@neutrinoceros neutrinoceros deleted the tst/cp311-313 branch August 22, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants