Update build scripts to Visual Studio 2026 #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hello. The CI's are not building. Assuming you'll have the same issue on all the PR's you submitted. |
Author
The support for the "Visual Studio 18 2026" generator was added in CMake 4.2.0 |
Collaborator
|
Okay, so looking at: https://github.com/actions/runner-images/blob/main/images/windows/Windows2025-Readme.md It looks like they are at CMake 3.31.6. MacOS runners appear to be at 4.2.0. I'm not sure if we want to go putting in changes to all the CI's right now to manually upgrade cmake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.