Remove unused LimitedGroupMember, Remerge GroupLimitedMember with GroupMember

openapi/components/paths/groups.yaml

@@ -25,7 +25,7 @@
           $ref: ../responses/files/FileNotFoundError.yaml
   /groups:
     get:
       operationId: searchGroups
       summary: Search Group
       description: Searches Groups by name or shortCode
       tags:
@@ -96,8 +96,8 @@
       security:
         - authCookie: []
       responses:
         "200":
           $ref: ../responses/groups/GroupResponse.yaml
         "401":
           $ref: ../responses/MissingCredentialsError.yaml
         "404":
@@ -111,13 +111,13 @@
       requestBody:
         content:
           application/json:
             schema:
               $ref: ../requests/UpdateGroupRequest.yaml
       security:
         - authCookie: []
       responses:
         "200":
           $ref: ../responses/groups/GroupResponse.yaml
         "401":
           $ref: ../responses/MissingCredentialsError.yaml
         "404":
@@ -129,11 +129,11 @@
       tags:
         - groups
       parameters:
         - name: hardDelete
           required: false
           in: query
           schema:
             type: boolean
       security:
         - authCookie: []
       responses:
@@ -204,7 +204,7 @@
     parameters:
       - $ref: ../parameters.yaml#/groupId
     get:
       operationId: getGroupAuditLogEntryTypes
       summary: Get Group Audit Log Entry Types
       description: Returns a list of audit log entry types for which the group has entries.
       tags:
@@ -238,8 +238,8 @@
       security:
         - authCookie: []
       responses:
         "200":
           $ref: ../responses/groups/GroupAuditLogListResponse.yaml
         "401":
           $ref: ../responses/MissingCredentialsError.yaml
         "404":
@@ -248,7 +248,7 @@
     parameters:
       - $ref: ../parameters.yaml#/groupId
     get:
       operationId: getGroupBans
       summary: Get Group Bans
       description: Returns a list of banned users for a Group.
       tags:
@@ -297,7 +297,7 @@
     delete:
       operationId: unbanGroupMember
       summary: Unban Group Member
       description: Unbans a user from a Group.
       tags:
         - groups
       security:
@@ -344,13 +344,13 @@
         required: true
         content:
           application/json:
             schema:
               $ref: ../requests/CreateGroupGalleryRequest.yaml
       security:
         - authCookie: []
       responses:
         "200":
           $ref: ../responses/groups/GroupGalleryResponse.yaml
         "401":
           $ref: ../responses/MissingCredentialsError.yaml
         "404":
@@ -360,7 +360,7 @@
       - $ref: ../parameters.yaml#/groupId
       - $ref: ../parameters.yaml#/groupGalleryId
     get:
       operationId: getGroupGalleryImages
       summary: Get Group Gallery Images
       description: Returns a list of images for a Group gallery.
       tags:
@@ -392,13 +392,13 @@
       requestBody:
         content:
           application/json:
             schema:
               $ref: ../requests/UpdateGroupGalleryRequest.yaml
       security:
         - authCookie: []
       responses:
         "200":
           $ref: ../responses/groups/GroupGalleryResponse.yaml
         "401":
           $ref: ../responses/MissingCredentialsError.yaml
         "404":
@@ -489,7 +489,7 @@
     parameters:
       - $ref: ../parameters.yaml#/groupId
     get:
       operationId: getGroupInstances
       summary: Get Group Instances
       description: Returns a list of group instances
       tags:
@@ -497,8 +497,8 @@
       security:
         - authCookie: []
       responses:
         "200":
           $ref: ../responses/groups/GroupInstanceListResponse.yaml
         "401":
           $ref: ../responses/MissingCredentialsError.yaml
         "404":
@@ -507,7 +507,7 @@
     parameters:
       - $ref: ../parameters.yaml#/groupId
     get:
       operationId: getGroupInvites
       summary: Get Group Invites Sent
       description: Returns a list of members that have been invited to the Group.
       tags:
@@ -648,7 +648,7 @@
     parameters:
       - $ref: ../parameters.yaml#/groupId
     get:
       operationId: getGroupMembers
       summary: List Group Members
       description: |-
         Returns a List of all **other** Group Members. This endpoint will never return the user calling the endpoint.
@@ -708,14 +708,14 @@
     get:
       operationId: getGroupMember
       summary: Get Group Member
-      description: Returns a LimitedGroup Member.
+      description: Returns a GroupMember.
       tags:
         - groups
       security:
         - authCookie: []
       responses:
         "200":
-          $ref: ../responses/groups/GroupLimitedMemberResponse.yaml
+          $ref: ../responses/groups/GroupMemberResponse.yaml
         "401":
           $ref: ../responses/MissingCredentialsError.yaml
         "403":
@@ -737,7 +737,7 @@
         - authCookie: []
       responses:
         "200":
-          $ref: ../responses/groups/GroupLimitedMemberResponse.yaml
+          $ref: ../responses/groups/GroupMemberResponse.yaml
         "401":
           $ref: ../responses/MissingCredentialsError.yaml
         "404":

openapi/components/schemas/GroupMember.yaml

@@ -1,26 +1,31 @@
 title: GroupMember
 type: object
+description: May be null when attempting to retrieve group membership for a user who is not part of the group
+nullable: true
 properties:
   acceptedByDisplayName:
     type: string
+    description: Only missing when explicitly fetching own user.
     nullable: true
   acceptedById:
     type: string
+    description: Only missing when explicitly fetching own user.
     nullable: true
   bannedAt:
     type: string
-    description: "Only visible via the /groups/:groupId/members endpoint, **not** when fetching a specific user."
+    description: Only missing when explicitly fetching own user.
     nullable: true
     format: date-time
   createdAt:
     type: string
-    description: "Only visible via the /groups/:groupId/members endpoint, **not** when fetching a specific user."
+    description: Only missing when explicitly fetching own user.
     nullable: true
     format: date-time
   groupId:
     $ref: ./GroupID.yaml
   hasJoinedFromPurchase:
     type: boolean
+    description: Missing when explicitly fetching own user, or when group isn't linked to a purchase.
   id:
     $ref: ./GroupMemberID.yaml
   isRepresenting:
@@ -33,6 +38,7 @@ properties:
     default: false
   isSubscribedToEventAnnouncements:
     type: boolean
+    description: Only missing when explicitly fetching own user.
   joinedAt:
     type: string
     nullable: true
@@ -47,7 +53,7 @@ properties:
       $ref: ./GroupRoleID.yaml
   managerNotes:
     type: string
-    description: "Only visible via the /groups/:groupId/members endpoint, **not** when fetching a specific user."
+    description: Only missing when explicitly fetching own user.
     nullable: true
   membershipStatus:
     $ref: ./GroupMemberStatus.yaml
@@ -57,9 +63,20 @@ properties:
       $ref: ./GroupRoleID.yaml
   user:
     $ref: ./GroupMemberLimitedUser.yaml
-    nullable: true
   userId:
     $ref: ./UserID.yaml
   visibility:
     type: string
     example: visible
+required:
+  - groupId
+  - id
+  - isRepresenting
+  - isSubscribedToAnnouncements
+  - joinedAt
+  - lastPostReadAt
+  - mRoleIds
+  - membershipStatus
+  - roleIds
+  - userId
+  - visibility

openapi/components/schemas/GroupMemberLimitedUser.yaml

@@ -1,6 +1,7 @@
 title: GroupMemberLimitedUser
 type: object
 description: "Only visible via the /groups/:groupId/members endpoint, **not** when fetching a specific user."
+nullable: true
 properties:
   currentAvatarTags:
     type: array