don't raise exceptions due normal usage #124
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Don't raise while filling initial results into extracted category: the old code added 'undefined' object as initial single element in TMNQueries.extracted, and this randomly lead to problems, especially if actual results were not extracted (for example non-latin results only) 2. Don't produce network errors on Validate button (split feeds by | like in apply) 3. Don't raise errors on mostly non-latin-alphabet feeds: if feed returns only spaces - don't add it. Tested on chrome 77.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't raise while filling initial results into extracted category:
the old code added 'undefined' object
as initial single element in TMNQueries.extracted,
and this randomly lead to problems,
especially if actual results were not extracted
(for example non-latin results only)
Don't produce network errors on Validate button
(split feeds by | like in apply)
Don't raise errors on custom mostly non-latin-alphabet feeds:
if feed returns only spaces - don't add it.
This should help #111
Tested on chrome 77.