Skip to content

Conversation

@couthcommander
Copy link
Contributor

@couthcommander couthcommander commented Dec 4, 2025

In addition to #485, this also changes behavior that completes #464

@jubilee2
Copy link
Collaborator

jubilee2 commented Dec 8, 2025

The changes look solid — the inline conflict handling with on.exit makes the restore logic much safer and easier to follow. I appreciate the added test ensuring role assignments remain intact even if importUsers fails.

@obregos , have you had a chance to run the unit tests locally to confirm everything passes

@obregos
Copy link
Collaborator

obregos commented Dec 8, 2025

@jubilee2 all tests are passing [ FAIL 0 | WARN 0 | SKIP 12 | PASS 2058 ]

@jubilee2
Copy link
Collaborator

jubilee2 commented Dec 8, 2025

Thank you Savannah

@couthcommander couthcommander merged commit e4158d0 into main Dec 8, 2025
6 of 7 checks passed
@spgarbet spgarbet deleted the issue-485-protect-role branch January 6, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants