Skip to content

Conversation

@flesueur
Copy link
Contributor

@flesueur flesueur commented May 9, 2025

Hi,

This PR adds :

  • since parameter, exposed by the API, to the python binding;
  • pagination, to retrieve all results matching the query.

I'm not very confident in the while condition to detect that we got all results, maybe another test would fit better ?

Cheers,
François

@Rafiot
Copy link
Collaborator

Rafiot commented May 9, 2025

Thank you for the PR!

I'll need to play a bit with it, but I think it wound be better to stop when the length of the response is to the limit, I fear the request as it is could fail is weird ways.

@Rafiot Rafiot self-assigned this May 9, 2025
@flesueur
Copy link
Contributor Author

flesueur commented May 9, 2025

Something like that ? Length of the response could be calculated in a reduce one-liner, but I'm not sure if it would help readability.

@flesueur
Copy link
Contributor Author

Hi,

I saw some tests failed (seems redis) and some others infinitely looped. It does not seem related to my code, when I launch tests on my side on the changed function it looks ok.

Just to be sure, are u expecting something from me ?

Cheers
François

@Rafiot Rafiot merged commit ea47f31 into vulnerability-lookup:main Jun 12, 2025
4 of 8 checks passed
@Rafiot
Copy link
Collaborator

Rafiot commented Jun 12, 2025

Sorry, I completely forgot about this one. I'm merging it now but a bit differently, as I just added iterators on other endpoints, and I'm trying to keep it consistent.

@flesueur
Copy link
Contributor Author

Great ! Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants