-
Notifications
You must be signed in to change notification settings - Fork 11
Generate address from output script #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sekulicd
wants to merge
38
commits into
vulpemventures:master
Choose a base branch
from
sekulicd:address_from_script
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
3d67bf2
added factory method FromPublicKeys for creating multiscript payment
sekulicd cc3bf1f
fix merge conflicts
sekulicd 46662ff
Merge remote-tracking branch 'upstream/master'
sekulicd 4c8baee
Merge remote-tracking branch 'upstream/master'
sekulicd c46b796
Merge remote-tracking branch 'upstream/master'
sekulicd c7665a1
Merge remote-tracking branch 'upstream/master'
sekulicd 50ed1cc
Merge remote-tracking branch 'upstream/master'
sekulicd a4c66c3
Merge remote-tracking branch 'upstream/master'
sekulicd 33e70ef
Merge remote-tracking branch 'upstream/master'
sekulicd 84f5e8e
Merge remote-tracking branch 'upstream/master'
sekulicd eb921b6
Merge remote-tracking branch 'upstream/master'
sekulicd 3a8583f
Merge remote-tracking branch 'upstream/master'
sekulicd b8c87cc
Merge remote-tracking branch 'upstream/master'
sekulicd 1efdee4
Merge remote-tracking branch 'upstream/master'
sekulicd 97e95fc
Merge remote-tracking branch 'upstream/master'
sekulicd fe6bffd
Merge remote-tracking branch 'upstream/master'
sekulicd 0798fd1
Merge remote-tracking branch 'upstream/master'
sekulicd b69eb30
merge with master
sekulicd b13d220
Merge remote-tracking branch 'upstream/master'
sekulicd 831f1ac
Merge remote-tracking branch 'upstream/master'
sekulicd 5f3c1d3
Merge remote-tracking branch 'upstream/master'
sekulicd 9b78b6b
Merge remote-tracking branch 'upstream/master'
sekulicd 4cbd8fb
Merge remote-tracking branch 'upstream/master'
sekulicd 78a1cbb
Merge remote-tracking branch 'upstream/master'
sekulicd 6e453bb
Merge remote-tracking branch 'upstream/master'
sekulicd ed46ed5
Merge remote-tracking branch 'upstream/master'
sekulicd 85762c0
Merge remote-tracking branch 'upstream/master'
sekulicd 3f397b9
Merge remote-tracking branch 'upstream/master'
sekulicd d22a94f
Merge remote-tracking branch 'upstream/master'
sekulicd d0343d3
Merge remote-tracking branch 'upstream/master'
sekulicd 903b9a7
Merge remote-tracking branch 'upstream/master'
sekulicd 634fc5d
Merge remote-tracking branch 'upstream/master'
sekulicd 06066ff
Merge remote-tracking branch 'upstream/master'
sekulicd 941047d
Merge remote-tracking branch 'upstream/master'
sekulicd 84e4d4f
Merge remote-tracking branch 'upstream/master'
sekulicd b70d249
Merge remote-tracking branch 'upstream/master'
sekulicd d7d5dff
FromOutputScript
sekulicd 43dc3db
remove golanglint file
sekulicd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method should stay in
addresspackage and should not make use of the payment one, like a "raw" address builder.The idea is to allow the user to retrieve and address from an output script with either
addressorpayment. The former lacks such API, while the latter already provides the necessary ones.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, thing is that if adding it to address pkg can use payment cause of cyclic import.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to say that this function should be moved to
addressand its implementation must change so that it doesn't make use ofpayment's types/functions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest you don't look at the liquidjs-lib implementation, rather this function should analyze the incoming script to understand its type and encode it to an address using the proper format (base58, bech32...).
I would remove also the blinding key argument and return always an unconfidential address from an output script to keep it simple. The user can translate it to confidential with existing types and functions of the
addresspackage if needed.