refactor: use maps.Copy for cleaner map handling #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: russcoss <russcoss@outlook.com>
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the merge function to use Go 1.21's new maps.Copy function for cleaner and more idiomatic map copying operations.
- Imports the
mapspackage from Go's standard library - Replaces manual key-value iteration with
maps.Copyfunction - Renames function parameter to avoid naming conflict with imported package
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Author
|
@louisinger @tiero Hi, If there's anything need I to do, please feel free to let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a new function added in the go1.21 standard library, which can make the code more concise and easy to read.