Skip to content
This repository was archived by the owner on May 2, 2024. It is now read-only.

Conversation

@Lasibian
Copy link

Added blob data type.

The nextgen compiler (XE7 with target iOS) does not support the Contnrs unit. Therefore I've changed TObjectList to TObjectList. Also some adjustments were needed for the zero based strings.

The current version of Indy requires a cast from or to TBytes and TIdBytes.

Bugfix: when adding an integer or float argument and immediately reading it back, the byte order is reversed. Example:

var
  msg: TOSCMessage;
begin
  msg := TOSCMessage.Create('/test/x');
  msg.AddInteger(123);
  if msg.ArgumentAsInt[0] <> 123 then
    Writeln('fail ', msg.ArgumentAsInt[0]);
end;

In order to workaround that problem, I've changed the code, so that the byte order adjustment happens when reading or writing the arguments. This change should not affect existing code.

Added blob type, changes for iOS
Bugfix: when adding an integer or float argument and immediately reading
it back, the byte order is reversed
@joreg
Copy link
Member

joreg commented Jun 11, 2015

helo @Lasibian,

sorry for the late reply and thanks for your contribution. only: would you mind providing your changes again but as separate pull requests? i'd prefer merging smaller more readable commits. to my understanding at the moment your pullrequest mixes 4 changes:

  • add blob type
  • fix for iOS/nextgen
  • fix for zero based strings
  • byteorder

hope that would work for you.

Lasibian added 4 commits September 15, 2015 16:10
Changed trim so it only removes trailing #0 at the end, not all white
space characters
GetTypeTag: Bugfix for zero based string handling
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants