Issue 82 83 parmay matrix #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of the header structure in readParmayMatrix
Collaborator
Author
|
Update: as this PR was not yet merged, I have updated the Parmay Matrix website in documentation in this same branch. |
… with number of observed packets
…version in r-lib/actions, and small adjustment to r_ubuntuOnly.yml
… calculate the mean
…s referent for timestamps AND improved handling of first-last corrupted packets
…re read, then GGIR will do usual data quality checks
vincentvanhees
approved these changes
Nov 21, 2025
Member
vincentvanhees
left a comment
vincentvanhees
left a comment
There was a problem hiding this comment.
thanks Jairo, also for updating the GitHub workflow files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #82 => all raw accelerometer and gyroscope values were scaled using a denominator of 32767, regardless of sign. This ignores the asymmetry of two's complement representation for 16-bit signed integers (range: -32768 to +32767). Now this is fixed. The maximum expected error with the previous approach was ~0.2 m_g_ for accelerometer and ~0.05 º/s for gyroscope.
Fixes #83 => fixes a small documentation error in
readParmayMatrix. The byte positions of the "MDTC" header string and the total packet count were mistakenly swapped in the documentation.Fixes #87 => Parmay Matrix website is now updated in README and readParmayMatrix function documentation.
Fixes #88 => Improved handling of files when the total number of packets declared in the binary file header (headerPackeNum) does not exactly match the actual number of packet headers (MDTCPACK) observed in the file (the manufacturer confirms this may occur and they ensure that the available packets are reliable).
Additionally, I updated the github workflows as they were not passing. I used the latest version of test-coverage and r-cmd-check-standard and slightly modified the r-cmd-basic check.
Checklist before merging:
NEWS.mdwith a user-readable summary. Please, include references to relevant issues or PR discussions.DESCRIPTIONfile, if you think you made a significant contribution.