Skip to content

Adding a dynamic way to include arbitrary dependencies of Wagtail #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saevarom wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adding a dynamic way to include arbitrary dependencies of Wagtail #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e4b657
Adding a dynamic way to include arbitrary dependencies of Wagtail
saevarom Jun 20, 2022
9447b00
Add additional items to docker ignore
zerolab Oct 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,8 @@
**/Vagrantfile
**/.devcontainer
**/.vscode
**/.tox
**/build/
**/dist/
**/venv/
**/.venv/
10 changes: 5 additions & 5 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ COPY ./wagtail /code/wagtail/
RUN cd /code/wagtail/ \
&& pip install -e .[testing,docs]

# Install Willow from the host. This folder will be overwritten by a volume mount during run time (so that code
# changes show up immediately), but it also needs to be copied into the image now so that Willow can be pip install'd.
COPY ./libs/Willow /code/willow/
RUN cd /code/willow/ \
&& pip install -e .[testing]
# Install Willow and possibly other dependencies from the host. This folder will be overwritten by a volume mount during
# run time (so that code changes show up immediately), but it also needs to be copied into the image now so that Willow
# can be pip install'd.
COPY ./libs /code/libs
RUN cd /code/libs/ && pip install -e $(find * -maxdepth 0 -type d)
8 changes: 5 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,12 +230,14 @@ git remote add upstream git@github.com:wagtail/wagtail.git
git pull --all
```

Contributing to Willow
----------------------
Contributing to Willow and other Wagtail dependencies
-----------------------------------------------------

You can use the same setup to contribute to Willow.
You can use the same setup to contribute to Willow and other Wagtail dependencies.
You simply do the same operations to fork the Willow project and point your local copy of Willow to your fork.

You can add dependencies by cloning the repository into the `libs` folder and then rebuild your container.
The Dockerfile should pick up your library and install it from the local source.

TODO
----
Expand Down