Add optional Elasticsearch service #88
Conversation
| - xpack.security.enabled=false | ||
| - discovery.type=single-node |
There was a problem hiding this comment.
This is to simplify accessing / running locally (single node, no security). I’ve copy-pasted this from existing projects, not sure how we arrived at those specific settings. It works.
There was a problem hiding this comment.
Yes, without xpack.security.enabled=false the Elasticsearch server will reject requests from the Django server process because Elasticsearch requires HTTPS by default. I ran into this while working on wagtail/wagtail#12862 yesterday: https://stackoverflow.com/questions/71492404
I also use discovery.type=single-node per the example in https://hub.docker.com/_/elasticsearch, but I haven't tried if it works without that.
The Elasticsearch GitHub Action we use in Wagtail's CI has a few more parameters, including both we set here: https://github.com/getong/elasticsearch-action/blob/v1.3/entrypoint.sh#L7
laymonage
left a comment
laymonage
left a comment
There was a problem hiding this comment.
Would be nice to also get the requirements automatically installed somehow, but I think this is a good first step!
| - xpack.security.enabled=false | ||
| - discovery.type=single-node |
There was a problem hiding this comment.
Yes, without xpack.security.enabled=false the Elasticsearch server will reject requests from the Django server process because Elasticsearch requires HTTPS by default. I ran into this while working on wagtail/wagtail#12862 yesterday: https://stackoverflow.com/questions/71492404
I also use discovery.type=single-node per the example in https://hub.docker.com/_/elasticsearch, but I haven't tried if it works without that.
The Elasticsearch GitHub Action we use in Wagtail's CI has a few more parameters, including both we set here: https://github.com/getong/elasticsearch-action/blob/v1.3/entrypoint.sh#L7
2 participants
Fixes #3. I chose to keep it simple and leave the service in the same compose file.