Skip to content

Fix bug to pass resource parameters to ray task options() #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eywalker merged 2 commits into from
Nov 11, 2025
Merged

Fix bug to pass resource parameters to ray task options() #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a01da5
Fix bug to pass resource parameters to ray task options()
Nov 5, 2025
d18336c
Prevent run_async from removing tag columns when processing existing …
Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/orcapod/core/pods.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,7 @@ def call(
values = execution_engine.submit_sync(
self.function,
fn_kwargs=input_dict,
engine_opts=execution_engine_opts,
**(execution_engine_opts or {}),
)
else:
values = self.function(**input_dict)
Expand Down Expand Up @@ -490,7 +490,9 @@ async def async_call(
if execution_engine is not None:
# use the provided execution engine to run the function
values = await execution_engine.submit_async(
self.function, fn_kwargs=input_dict, engine_opts=execution_engine_opts
self.function,
fn_kwargs=input_dict,
**(execution_engine_opts or {})
)
else:
values = self.function(**input_dict)
Expand Down
15 changes: 11 additions & 4 deletions src/orcapod/core/streams/pod_node_stream.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,18 @@ async def run_async(
.drop_columns([constants.INPUT_PACKET_HASH])
)

existing = (
all_results.filter(pc.is_valid(pc.field("_exists")))
.drop_columns(target_entries.column_names)
.drop_columns(["_exists"])
existing = all_results.filter(
pc.is_valid(pc.field("_exists"))
).drop_columns(
[
"_exists",
constants.INPUT_PACKET_HASH,
constants.PACKET_RECORD_ID,
*self.input_stream.keys()[1], # remove the input packet keys
]
# TODO: look into NOT fetching back the record ID
)

renamed = [
c.removesuffix("_right") if c.endswith("_right") else c
for c in existing.column_names
Expand Down
Loading