Corrected Acceleration Limited Max Speed #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously _cn could never significantly drop below its initial value, leading to cases where low accelerations meant it could never exceed a speed value of about 1361000 / sqrt(acceleration) This fix is to correct it such that the libraries speed limit is the only thing limiting the maximum speed, This may have the consequence of changing the acceleration scaling at higher speeds slightly, as it no longer rolls off, instead increasing to the cruise phase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously _cn could never significantly drop below its initial value, leading to cases where low accelerations meant it could never exceed a speed value of about 1361000 / sqrt(acceleration)
This fix is to correct it such that the libraries speed limit is the only thing limiting the maximum speed, This may have the consequence of changing the acceleration scaling at higher speeds slightly, as it no longer rolls off, instead increasing to the cruise phase