Skip to content

Fix syntax errors in waiting.md code samples #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KrauseFx wants to merge 1 commit into
base: source
Choose a base branch
from
Open

Fix syntax errors in waiting.md code samples #162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions _guides/waiting.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ condition needs to be met. `#wait_until` will execute the block until a truthy r

{% highlight ruby %}
browser.wait_until { |b| b.title == "Foo" }
browser.window(title: "Foo")wait_while(&:exists?)
browser.window(title: "Foo").wait_while(&:exists?)
browser.alert.wait_until { |a| a.text == "foo" }
browser.button(name: 'submit').wait_until(&:enabled?)
{% endhighlight %}
Expand All @@ -75,7 +75,7 @@ Note that it is encouraged to use `#to_proc` syntax when possible:

{% highlight ruby %}
# Good
browser.text_field(title: 'Search').wait_until(message: "Can't find it" &:present?)
browser.text_field(title: 'Search').wait_until(message: "Can't find it", &:present?)

# Less Good
browser.text_field(title: 'Search').wait_until(message: "Can't find it") { |el| el.present? }
Expand Down