feat: deployment fixes + readme instructions #1
Conversation
| 'UFragmentsPolicy', | ||
| deployer, | ||
| 'initialize(address,address,uint256)', | ||
| [owner, ampl.address, INITIAL_CPI.toString()], |
There was a problem hiding this comment.
why don't we have the initial CPI?
There was a problem hiding this comment.
needs more investigation; initialize() function only provides two vals right now
| | UFragments deployed to | 0x0Df6D221DbB5cabAc86777E9FF6B455a1b2cFAD4 | | ||
| | Implementation | 0x86B1c1eD8E4161eAbE7c78D182ef16b9b49c9146 | | ||
| | Market oracle to | 0x15a98688AB4274C578d19874D5Cf3B2991d08A31 | | ||
| | CPI oracle to | 0x6b06Eb8f79457bC036d1a50e4bDcbeBD7AdD50c4 | |
There was a problem hiding this comment.
and these oracles are they also part of AMPL and to be forkable with the same license or how does this work?
There was a problem hiding this comment.
bc we need to use a custom data feed most likely then
There was a problem hiding this comment.
is everything within the same repository
There was a problem hiding this comment.
ok cool stuff, the better we understand the oracle part the better! Since that will be the part we will need to change!
| RATE_REPORT_EXPIRATION_SEC, | ||
| RATE_REPORT_DELAY_SEC, | ||
| RATE_MIN_PROVIDERS, | ||
| 1 // TODO - NEEDS ELABORATION |
There was a problem hiding this comment.
where is this value coming from?
1 sounds for me like the base for CPI/inflation. Without having any further context.
There was a problem hiding this comment.
I was just adding it to make it run, as current constructor is defined that way.
|
---- would keep it open to see the changes |
Made some changes to get a running example