Skip to content

Conversation

@google-labs-jules
Copy link
Contributor

The api-scraper was attempting to start a defunct Python-based yfinance-proxy when run with the --yahoo flag. This change updates the NewYahooProxyClient function to use the Go-based YahooFinanceClient, which directly queries the Yahoo Finance API. This resolves the test failures caused by the "connection refused" and "401 Unauthorized" errors. The call to proxyCl.Stop() was also removed from main.go as it is no longer needed.


PR created automatically by Jules for task 2406160525467598296 started by @hunterjsb

…nance-proxy` when run with the `--yahoo` flag. This change updates the `NewYahooProxyClient` function to use the Go-based `YahooFinanceClient`, which directly queries the Yahoo Finance API. This resolves the test failures caused by the "connection refused" and "401 Unauthorized" errors. The call to `proxyCl.Stop()` was also removed from `main.go` as it is no longer needed.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

@hunterjsb hunterjsb closed this Nov 17, 2025
@hunterjsb hunterjsb deleted the fix/yfinance-proxy-client branch November 17, 2025 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants