Skip to content

feat: Unpublish #5579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kof merged 15 commits into from
Jan 22, 2026
Merged

feat: Unpublish #5579

kof merged 15 commits into from
Jan 22, 2026

Conversation

@kof
Copy link
Member

@kof kof commented Jan 20, 2026

Description

  1. What is this PR about (link the issue and add a short description)

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

kof added 15 commits January 20, 2026 19:29
@kof
feat: add unpublish functionality for domains
d2b65b4 
- Add unpublishBuild function that removes domain from deployment or deletes build if no domains remain
- Add unpublish tRPC procedure in domain router
- Add Unpublish button to wstd domain section with info icon tooltip
- Add Unpublish button to custom domains section
- Disable domain renaming when project is published
- Make loadDevBuildByProjectId resilient to multiple dev builds
@kof
cr
0817614
@kof
fix: align UnpublishInput schema with SaaS
f79eed1
@kof
fix: remove unused env variable
49fbd69
@kof
fix: unpublish worker before updating DB
b8762fc
@kof
fix: check latestBuildVirtual existence instead of deployment
43d8f2f
@kof
fix: always unpublish DB, add domain to success response
a6d1059
@kof
fix: rename domain to message in success response
362212e
@kof
fix: use human-readable success message
edeccb9
@kof
fix: use server message in unpublish toast
a175f1a
@kof
fix: include domain in error message for unpublish
f5f5562
@kof
fix unpublish
faacb21
@kof
"myproject.wstd.work" → "myproject", "custom.com" → "custom.com"
939b94f
@kof
feat: add unpublish functionality for domains
38826e6 
- Add unpublish button for project domain and custom domains
- Call edge-api deployment.unpublish to delete worker
- Remove domain from all builds in DB (not just latest)
- Disable domain renaming only when that specific domain is published
- Add PUBLISHER_HOST to deployment context for domain suffix handling
- Add error details to unpublish error messages
@kof
fix: only disable domain renaming when wstd domain is published
548929e 
Check if the specific wstd domain is published, not just any domain.
This allows renaming when only custom domains are published.
@kof kof merged commit 4f27152 into main Jan 22, 2026
27 of 29 checks passed
@kof kof deleted the unpublish.staging branch January 22, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kof