feat: metamask connector upgrade #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffmcgee725
reviewed
Nov 19, 2025
packages/connectors/src/metaMask.ts
Outdated
| isReconnecting?: boolean | undefined | ||
| withCapabilities?: withCapabilities | boolean | undefined | ||
| }) { | ||
| // TODO: better handling when not providing a chainId? |
Collaborator
There was a problem hiding this comment.
What could we consider as "better handling" ?
I believe defaulting to mainnet seems like a good approach here
ffmcgee725
reviewed
Nov 19, 2025
packages/connectors/src/metaMask.ts
Outdated
| try { | ||
| const result = await metamask.connect({ | ||
| chainId: chainId, | ||
| account: undefined, |
Collaborator
There was a problem hiding this comment.
do we need to explicitly set account to undefined.
If not, think it's cleaner to omit it altogether and just have
const result = await metamask.connect({ chainId: chainId });
ffmcgee725
reviewed
Nov 19, 2025
packages/connectors/src/metaMask.ts
Outdated
| async switchChain({ addEthereumChainParameter, chainId }) { | ||
| const provider = await this.getProvider() | ||
|
|
||
| async switchChain({ addEthereumChainParameter, chainId }) { |
Collaborator
There was a problem hiding this comment.
Not suggesting anything in particular, but want to understand
do you remember why we are now deviating from doing
await provider.request({
method: 'wallet_switchEthereumChain',
params: [{ chainId: numberToHex(chainId) }],
})like before ?
EDIT: as I read further, perhaps the call to
await metamask.switchChain({ chainId, chainConfiguration })handles this.
4 tasks
…ade-update feat: update connector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup:
connect-monorepoandyarn && yarn buildfeat/metamask-connector-upgrade)pnpm ito install depspnpm run dev:reactto launch the playground