feat(gradle): allow skipping build check for publish/release #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Behavior of skip-build parameter for gradle-library.yml and gradle-service.yml workflows changed.
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the CI workflows for Gradle projects by changing the behavior of the skip-build parameter and introducing a new parameter for publish workflows.
- Modified skip-build description and related conditional checks in gradle-service.yml and gradle-library.yml
- Introduced a skip-check parameter in gradle-service-publish.yml and gradle-library-publish.yml, mapped to skip-build in job inputs
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/gradle-service.yml | Updated skip-build description and removed its condition from if-clauses |
| .github/workflows/gradle-service-publish.yml | Added skip-check parameter and mapped it to skip-build |
| .github/workflows/gradle-library.yml | Updated skip-build description and adjusted conditional logic |
| .github/workflows/gradle-library-publish.yml | Added skip-check parameter and mapped it to skip-build |
Comments suppressed due to low confidence (2)
.github/workflows/gradle-service-publish.yml:38
- [nitpick] The parameter 'skip-check' is introduced in this workflow while other configurations use 'skip-build'. Consider renaming it to 'skip-build' for consistency across workflows.
skip-check:
.github/workflows/gradle-library-publish.yml:26
- [nitpick] The new 'skip-check' parameter here could be renamed to 'skip-build' to align with similar settings in other workflows, improving consistency.
skip-check:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Behavior of skip-build parameter for gradle-library.yml and gradle-service.yml workflows changed.