Skip to content

Conversation

@daohu527
Copy link
Contributor

@daohu527 daohu527 commented Nov 8, 2025

add nx

@daohu527 daohu527 requested a review from lykling November 8, 2025 13:40
DOCKER_IMAGE_TAG_X86_64=${DOCKER_IMAGE_TAG_X86_64:="dev-x86_64-20.04-20250713_1555"}
DOCKER_IMAGE_TAG_X86_64_TESTING=${DOCKER_IMAGE_TAG_X86_64_TESTING:="dev-x86_64-20.04-20250710_2109"}
DOCKER_IMAGE_TAG_AARCH64=${DOCKER_IMAGE_TAG_AARCH64:="dev-aarch64-22.04-20251107_1200"}
[[ "$RELEASE_TARGET" == "20.04" ]] && DOCKER_IMAGE_TAG_AARCH64=${DOCKER_IMAGE_TAG_AARCH64:="dev-aarch64-20.04-20250714_2123"}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The selection depends on the operating system and chip; a refactoring is required.

Copy link
Member

@lykling lykling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no major issues overall, you can double check the logic of the new dockerfile

RUN apt-get update && apt-get install -y --no-install-recommends sudo gnupg2 curl ca-certificates \
&& rm -rf /var/lib/apt/lists/* /usr/local/bin/cmake /usr/local/share/cmake-3.14

RUN apt update && DEBIAN_FRONTEND=noninteractive TZ="Asian/China" apt-get -y install tzdata
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asian/China invalid,use Asia/Shanghai instead

RUN bash /opt/apollo/installers/install_gpu_support.sh
RUN bash /opt/apollo/installers/install_release_deps.sh

RUN bash /opt/apollo/installers/post_install.sh dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post install has an action to modify chfn for the cyber phase. Now, starting directly from the base image, we need to see if it is still necessary to execute it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants